Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 645693004: Canvas 2D: Remove CompositeOperator and WebBlendMode parameters in drawImageInternal(). (Closed)

Created:
6 years, 2 months ago by dshwang
Modified:
6 years, 2 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Canvas 2D: Remove CompositeOperator and WebBlendMode parameters in drawImageInternal(). fillInternal() and strokeInternal() don't have those parameters. CompositeOperator and WebBlendMode parameters exists due to drawImageFromRect(), which is non-standard API and will maybe deprecated. Give up the optimization for only drawImageFromRect(), because it's confused why drawImageInternal() doesn't set current global composite before calling drawVideo(). In addition, include some clean-up. 1. remove redundant "blink::". 2. merge fullCanvasCompositedFill() with fullCanvasCompositedStroke(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183704

Patch Set 1 #

Patch Set 2 : Make drawImageInternal() simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -50 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 17 chunks +27 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dshwang
Could you review this clean-up?
6 years, 2 months ago (2014-10-14 15:32:32 UTC) #2
Justin Novosad
On 2014/10/14 15:32:32, dshwang wrote: > Could you review this clean-up? lgtm
6 years, 2 months ago (2014-10-14 15:44:42 UTC) #3
dshwang
On 2014/10/14 15:44:42, junov wrote: > On 2014/10/14 15:32:32, dshwang wrote: > > Could you ...
6 years, 2 months ago (2014-10-14 16:34:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645693004/20001
6 years, 2 months ago (2014-10-14 16:36:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31757)
6 years, 2 months ago (2014-10-14 19:26:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645693004/20001
6 years, 2 months ago (2014-10-14 21:55:10 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 23:08:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183704

Powered by Google App Engine
This is Rietveld 408576698