Source/core/frame/LocalFrame.cpp - Issue 645693003: [DevTools] Console Message Storage moved from top local frame to frame host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 645693003: [DevTools] Console Message Storage moved from top local frame to frame host (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/FrameConsole.cpp ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/inspector/CodeGeneratorInstrumentation.py » ('j') | Source/core/inspector/InspectorInstrumentation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 7c852b36fb9cea1ed03e8351197e60cb2319737b..f66e49f98804e021cd9f9f747410cc6d676002d1 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -308,8 +308,8 @@ void LocalFrame::setDOMWindow(PassRefPtrWillBeRawPtr<LocalDOMWindow> domWindow)

// die with the window. And the registered DOMWindowProperty instances that don't,

// only keep a weak reference to this frame, so there's no need to be

// explicitly notified that this frame is going away.

- if (m_domWindow) {

- console().messageStorage()->frameWindowDiscarded(m_domWindow.get());

+ if (m_domWindow && host()) {

+ host()->consoleMessageStorage().frameWindowDiscarded(m_domWindow.get());

InspectorInstrumentation::frameWindowDiscarded(this, m_domWindow.get());

}

if (domWindow)