Get IME's to work in Chrome OS mode on Windows 7.

chrome/browser/ui/views/app_list/win/app_list_service_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/app_list/win/app_list_service_win.h"
 
 #include <dwmapi.h>
 #include <sstream>
 
 #include "base/command_line.h"
@@ skipping 21 matching lines @@
 #include "chrome/browser/ui/views/app_list/win/app_list_win.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/app_list/views/app_list_view.h"
 #include "ui/base/win/shell.h"
+#include "ui/base/ui_base_switches.h"
 
 #if defined(GOOGLE_CHROME_BUILD)
 #include "chrome/installer/util/google_update_settings.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/updating_app_registration_data.h"
 #include "chrome/installer/util/util_constants.h"
 #endif  // GOOGLE_CHROME_BUILD
 
 // static
 AppListService* AppListService::Get(chrome::HostDesktopType desktop_type) {
-  if (desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)
+  if ((desktop_type == chrome::HOST_DESKTOP_TYPE_ASH) ||
+       (CommandLine::ForCurrentProcess()->HasSwitch(switches::kViewerConnect)))

[tapted, 2014/10/09 22:33:09]

This doesn't look right. Clicking the taskbar app launcher shortcut should still
show the desktop mode app launcher. Otherwise, if Chrome is in Ash mode a user
might not see the app launcher at all, since it pops up in Metro mode (or, e.g.,
a minimized window).

Note: launching Browser windows from it there should switch into Metro mode on
Windows 8. (On Windows 7 it should probably activate the Ash window, but I'm not
sure there's code to do that yet).

[ananta, 2014/10/09 22:55:02]

Creating a desktop environment breaks IME support as this triggers the input
method creation which is a singleton.

     return AppListServiceAsh::GetInstance();
 
   return AppListServiceWin::GetInstance();
 }
 
 // static
 void AppListService::InitAll(Profile* initial_profile) {
-  AppListServiceAsh::GetInstance()->Init(initial_profile);
-  AppListServiceWin::GetInstance()->Init(initial_profile);
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kViewerConnect)) {
+    AppListServiceAsh::GetInstance()->Init(initial_profile);
+  } else {

[tapted, 2014/10/09 22:33:09]

Bringing up the Ash service conditionally is probably OK (pretty sure it will
only get asked for when that flag is present). However, the desktop ServiceWin
should be unconditional (i.e. no `else`).

+    AppListServiceWin::GetInstance()->Init(initial_profile);
+  }
 }
 
 namespace {
 
 // Migrate chrome::kAppLauncherIsEnabled pref to
 // chrome::kAppLauncherHasBeenEnabled pref.
 void MigrateAppLauncherEnabledPref() {
   PrefService* prefs = g_browser_process->local_state();
   if (prefs->HasPrefPath(prefs::kAppLauncherIsEnabled)) {
     prefs->SetBoolean(prefs::kAppLauncherHasBeenEnabled,
@@ skipping 310 matching lines @@
   activation_tracker_.reset(new ActivationTrackerWin(this));
 }
 
 void AppListServiceWin::OnViewDismissed() {
   activation_tracker_->OnViewHidden();
 }
 
 void AppListServiceWin::MoveNearCursor(app_list::AppListView* view) {
   AppListWin::MoveNearCursor(view);
 }