Issue 645673004: DevTools: fix aggegated pie chart for JSFrame events on Timeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 645673004: DevTools: fix aggegated pie chart for JSFrame events on Timeline (Closed)

Created:
6 years, 2 months ago by yurys

Modified:
6 years, 2 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: fix aggegated pie chart for JSFrame events on Timeline JSFrame events are added in TimelineFlameChart and their selfTime is never calculated. These events are never added into the model as they are used only to draw the flame chart. When such event is selected we calculate its selfTime on the fly as duration - sum of children times. BUG=424507 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183893