Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 645673003: ozone: evdev: Minor refactor of device open (Closed)

Created:
6 years, 2 months ago by spang
Modified:
6 years, 2 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Minor refactor of device open Use a struct to reduce the number of arguments passed via the callback and clean up the surrounding code a bit. BUG=none TEST=events_unittests, link_freon Committed: https://crrev.com/de3b5291040214ae9cc8b4f0d2d3c4f95180d3e5 Cr-Commit-Position: refs/heads/master@{#299472}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -47 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev.h View 2 chunks +3 lines, -4 lines 0 comments Download
A ui/events/ozone/evdev/event_dispatch_callback.h View 1 chunk +18 lines, -0 lines 1 comment Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 7 chunks +55 lines, -38 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
spang
6 years, 2 months ago (2014-10-09 20:14:18 UTC) #2
kpschoedel
LGTM https://codereview.chromium.org/645673003/diff/1/ui/events/ozone/evdev/event_dispatch_callback.h File ui/events/ozone/evdev/event_dispatch_callback.h (right): https://codereview.chromium.org/645673003/diff/1/ui/events/ozone/evdev/event_dispatch_callback.h#newcode16 ui/events/ozone/evdev/event_dispatch_callback.h:16: } // namspace ui Nit: You don't KNOW, ...
6 years, 2 months ago (2014-10-09 20:56:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645673003/1
6 years, 2 months ago (2014-10-14 13:40:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 14:03:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 14:04:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de3b5291040214ae9cc8b4f0d2d3c4f95180d3e5
Cr-Commit-Position: refs/heads/master@{#299472}

Powered by Google App Engine
This is Rietveld 408576698