Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: ipc/mojo/ipc_channel_mojo_readers.h

Issue 645623006: Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/mojo/ipc_channel_mojo_readers.h
diff --git a/ipc/mojo/ipc_channel_mojo_readers.h b/ipc/mojo/ipc_channel_mojo_readers.h
index fae62adc7663f14828303019d372e759fba7a8cf..cadf453c393b24cabc90b376d3bf64871a1c0607 100644
--- a/ipc/mojo/ipc_channel_mojo_readers.h
+++ b/ipc/mojo/ipc_channel_mojo_readers.h
@@ -33,9 +33,9 @@ class MessageReader : public MessagePipeReader {
bool Send(scoped_ptr<Message> message);
// MessagePipeReader implementation
- virtual void OnMessageReceived() override;
- virtual void OnPipeClosed() override;
- virtual void OnPipeError(MojoResult error) override;
+ void OnMessageReceived() override;
+ void OnPipeClosed() override;
+ void OnPipeError(MojoResult error) override;
private:
ChannelMojo* owner_;
@@ -52,8 +52,8 @@ class ControlReader : public MessagePipeReader {
virtual bool Connect();
// MessagePipeReader implementation
- virtual void OnPipeClosed() override;
- virtual void OnPipeError(MojoResult error) override;
+ void OnPipeClosed() override;
+ void OnPipeError(MojoResult error) override;
protected:
ChannelMojo* owner_;
@@ -65,13 +65,13 @@ class ControlReader : public MessagePipeReader {
class ServerControlReader : public ControlReader {
public:
ServerControlReader(mojo::ScopedMessagePipeHandle pipe, ChannelMojo* owner);
- virtual ~ServerControlReader();
+ ~ServerControlReader() override;
// ControlReader override
- virtual bool Connect() override;
+ bool Connect() override;
// MessagePipeReader implementation
- virtual void OnMessageReceived() override;
+ void OnMessageReceived() override;
private:
MojoResult SendHelloRequest();
@@ -88,7 +88,7 @@ class ClientControlReader : public ControlReader {
ClientControlReader(mojo::ScopedMessagePipeHandle pipe, ChannelMojo* owner);
// MessagePipeReader implementation
- virtual void OnMessageReceived() override;
+ void OnMessageReceived() override;
private:
MojoResult RespondHelloRequest(MojoHandle message_channel);

Powered by Google App Engine
This is Rietveld 408576698