Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ipc/ipc_perftest_support.cc

Issue 645623006: Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_perftest_support.cc
diff --git a/ipc/ipc_perftest_support.cc b/ipc/ipc_perftest_support.cc
index e60de91ec60782d1584104a6ecf718e21c18409e..ab06ed61b94b5259d81d7f0530ad9868f2cd84f6 100644
--- a/ipc/ipc_perftest_support.cc
+++ b/ipc/ipc_perftest_support.cc
@@ -81,7 +81,7 @@ class ChannelReflectorListener : public Listener {
VLOG(1) << "Client listener up";
}
- virtual ~ChannelReflectorListener() {
+ ~ChannelReflectorListener() override {
VLOG(1) << "Client listener down";
latency_tracker_.ShowResults();
}
@@ -91,7 +91,7 @@ class ChannelReflectorListener : public Listener {
channel_ = channel;
}
- virtual bool OnMessageReceived(const Message& message) override {
+ bool OnMessageReceived(const Message& message) override {
CHECK(channel_);
PickleIterator iter(message);
@@ -142,9 +142,7 @@ class PerformanceChannelListener : public Listener {
VLOG(1) << "Server listener up";
}
- virtual ~PerformanceChannelListener() {
- VLOG(1) << "Server listener down";
- }
+ ~PerformanceChannelListener() override { VLOG(1) << "Server listener down"; }
agl 2014/10/21 17:49:49 Please don't make functions single line just becau
dcheng 2014/10/21 17:57:44 This is a clang-format change. I'm willing to make
void Init(Sender* sender) {
DCHECK(!sender_);
@@ -160,7 +158,7 @@ class PerformanceChannelListener : public Listener {
payload_ = std::string(msg_size_, 'a');
}
- virtual bool OnMessageReceived(const Message& message) override {
+ bool OnMessageReceived(const Message& message) override {
CHECK(sender_);
PickleIterator iter(message);

Powered by Google App Engine
This is Rietveld 408576698