Standardize usage of virtual/override/final in ipc/

ipc/ipc_send_fds_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_POSIX)
 #if defined(OS_MACOSX)
 extern "C" {
 #include <sandbox.h>
@@ skipping 15 matching lines @@
 #include "ipc/ipc_message_utils.h"
 #include "ipc/ipc_test_base.h"
 
 namespace {
 
 const unsigned kNumFDsToSend = 20;
 const char* kDevZeroPath = "/dev/zero";
 
 class MyChannelDescriptorListenerBase : public IPC::Listener {
  public:
-  virtual bool OnMessageReceived(const IPC::Message& message) override {
+  bool OnMessageReceived(const IPC::Message& message) override {
     PickleIterator iter(message);
 
     base::FileDescriptor descriptor;
 
     IPC::ParamTraits<base::FileDescriptor>::Read(&message, &iter, &descriptor);
 
     HandleFD(descriptor.fd);
     return true;
   }
 
  protected:
   virtual void HandleFD(int fd) = 0;
 };
 
 class MyChannelDescriptorListener : public MyChannelDescriptorListenerBase {
  public:
   explicit MyChannelDescriptorListener(ino_t expected_inode_num)
       : MyChannelDescriptorListenerBase(),
         expected_inode_num_(expected_inode_num),
         num_fds_received_(0) {
   }
 
   bool GotExpectedNumberOfDescriptors() const {
     return num_fds_received_ == kNumFDsToSend;
   }
 
-  virtual void OnChannelError() override {
-    base::MessageLoop::current()->Quit();
-  }
+  void OnChannelError() override { base::MessageLoop::current()->Quit(); }

[agl, 2014/10/21 17:49:50]

ditto (and elsewhere).

[dcheng, 2014/10/21 17:57:44]

See previous comment.

 
  protected:
-  virtual void HandleFD(int fd) override {
+  void HandleFD(int fd) override {
     // Check that we can read from the FD.
     char buf;
     ssize_t amt_read = read(fd, &buf, 1);
     ASSERT_EQ(amt_read, 1);
     ASSERT_EQ(buf, 0);  // /dev/zero always reads 0 bytes.
 
     struct stat st;
     ASSERT_EQ(fstat(fd, &st), 0);
 
     ASSERT_EQ(close(fd), 0);
@@ skipping 116 matching lines @@
 
 
 class MyCBListener : public MyChannelDescriptorListenerBase {
  public:
   MyCBListener(base::Callback<void(int)> cb, int fds_to_send)
       : MyChannelDescriptorListenerBase(),
         cb_(cb) {
     }
 
  protected:
-  virtual void HandleFD(int fd) override {
-    cb_.Run(fd);
-  }
+  void HandleFD(int fd) override { cb_.Run(fd); }
  private:
   base::Callback<void(int)> cb_;
 };
 
 std::pair<int, int> make_socket_pair() {
   int pipe_fds[2];
   CHECK_EQ(0, HANDLE_EINTR(socketpair(AF_UNIX, SOCK_STREAM, 0, pipe_fds)));
   return std::pair<int, int>(pipe_fds[0], pipe_fds[1]);
 }
 
@@ skipping 149 matching lines @@
   base::WaitableEvent received_;
 };
 
 TEST_F(IPCMultiSendingFdsTest, StressTest) {
   Run();
 }
 
 }  // namespace
 
 #endif  // defined(OS_POSIX)