Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: Source/core/page/Page.h

Issue 645623004: Reland "Streamline frame detach" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | Source/core/page/Page.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/Page.h
diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h
index 23dba172f050201ae213a1277647cfe7fc6e792b..efbfbf2b9584935956a3971e426ce71de751fd83 100644
--- a/Source/core/page/Page.h
+++ b/Source/core/page/Page.h
@@ -134,10 +134,6 @@ public:
bool openedByDOM() const;
void setOpenedByDOM();
- void incrementSubframeCount() { ++m_subframeCount; }
- void decrementSubframeCount() { ASSERT(m_subframeCount); --m_subframeCount; }
- int subframeCount() const { checkSubframeCountConsistency(); return m_subframeCount; }
-
PageAnimator& animator() { return *m_animator; }
Chrome& chrome() const { return *m_chrome; }
AutoscrollController& autoscrollController() const { return *m_autoscrollController; }
@@ -185,12 +181,6 @@ public:
StorageNamespace* sessionStorage(bool optionalCreate = true);
StorageClient& storageClient() const { return *m_storageClient; }
- // Don't allow more than a certain number of frames in a page.
- // This seems like a reasonable upper bound, and otherwise mutually
- // recursive frameset pages can quickly bring the program to its knees
- // with exponential growth in the number of frames.
- static const int maxNumberOfFrames = 1000;
-
PageVisibilityState visibilityState() const;
void setVisibilityState(PageVisibilityState, bool);
@@ -228,12 +218,6 @@ protected:
private:
void initGroup();
-#if ENABLE(ASSERT)
- void checkSubframeCountConsistency() const;
-#else
- void checkSubframeCountConsistency() const { }
-#endif
-
void setTimerAlignmentInterval(double);
void setNeedsLayoutInAllFrames();
@@ -277,7 +261,6 @@ private:
UseCounter m_useCounter;
- int m_subframeCount;
bool m_openedByDOM;
bool m_tabKeyCyclesThroughElements;
« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698