Source/core/frame/RemoteFrame.cpp - Issue 645623004: Reland "Streamline frame detach"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RemoteFrame.cpp

Issue 645623004: Reland "Streamline frame detach" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move frame count inc/dec to WebFrame append/removeChild Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/RemoteFrame.cpp

diff --git a/Source/core/frame/RemoteFrame.cpp b/Source/core/frame/RemoteFrame.cpp

index 462db56955865e8d4f034b7a052624b369480ffb..19c25da7ab56b38d49bf4dac00c1b3d263e18a8a 100644

--- a/Source/core/frame/RemoteFrame.cpp

+++ b/Source/core/frame/RemoteFrame.cpp

@@ -40,7 +40,7 @@ void RemoteFrame::navigate(Document& originDocument, const KURL& url, bool lockB

void RemoteFrame::detach()

{

detachChildren();

- m_host = nullptr;

+ Frame::detach();

}

void RemoteFrame::trace(Visitor* visitor)