Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: Source/core/frame/FrameHost.h

Issue 645623004: Reland "Streamline frame detach" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move frame count inc/dec to WebFrame append/removeChild Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameHost.h
diff --git a/Source/core/frame/FrameHost.h b/Source/core/frame/FrameHost.h
index 37dccda148597cfef4abfaba53e356e1e805a49f..aa94c51cd9f1c1262df56890b7c9cfe1dfaf1d52 100644
--- a/Source/core/frame/FrameHost.h
+++ b/Source/core/frame/FrameHost.h
@@ -82,6 +82,15 @@ public:
void trace(Visitor*);
+ // Don't allow more than a certain number of frames in a page.
+ // This seems like a reasonable upper bound, and otherwise mutually
+ // recursive frameset pages can quickly bring the program to its knees
+ // with exponential growth in the number of frames.
+ static const int maxNumberOfFrames = 1000;
+ void incrementSubframeCount() { ++m_subframeCount; }
+ void decrementSubframeCount() { ASSERT(m_subframeCount); --m_subframeCount; }
+ int subframeCount() const;
+
private:
explicit FrameHost(Page&);
@@ -90,6 +99,7 @@ private:
const OwnPtrWillBeMember<EventHandlerRegistry> m_eventHandlerRegistry;
AtomicString m_overrideEncoding;
+ int m_subframeCount;
};
}

Powered by Google App Engine
This is Rietveld 408576698