Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 645623003: Remove hack to suppress pseudo element names. (Closed)

Created:
6 years, 2 months ago by dsinclair
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Remove hack to suppress pseudo element names. Previously we suppressed the pseudoElement names in order to avoid rebaselines. Those are easy now, so fix the names. BUG=416453 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183505

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -36 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +176 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Julien - ping for review
Assuming the output of the dump is nicer, rs-LGTM
6 years, 2 months ago (2014-10-09 19:08:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645623003/50001
6 years, 2 months ago (2014-10-09 20:30:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31033)
6 years, 2 months ago (2014-10-09 21:58:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645623003/230001
6 years, 2 months ago (2014-10-10 00:25:55 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 03:52:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:230001) as 183505

Powered by Google App Engine
This is Rietveld 408576698