content/renderer/renderer_blink_platform_impl.h - Issue 645613002: [WebGL-chromium] Return meaningful information in WebGL context creation error message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_blink_platform_impl.h

Issue 645613002: [WebGL-chromium] Return meaningful information in WebGL context creation error message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/renderer_blink_platform_impl.h

diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h

index 9d881bffbe0027d20161cac9aadab7e6c18f331d..f5165119af54f82e47eeedf04982e0a7fad447a3 100644

--- a/content/renderer/renderer_blink_platform_impl.h

+++ b/content/renderer/renderer_blink_platform_impl.h

@@ -130,7 +130,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {

const blink::WebGraphicsContext3D::Attributes& attributes);

virtual blink::WebGraphicsContext3D* createOffscreenGraphicsContext3D(

const blink::WebGraphicsContext3D::Attributes& attributes,

- blink::WebGraphicsContext3D* share_context);

+ blink::WebGraphicsContext3D* share_context,

+ blink::WebGLInfo& gl_info);

piman 2014/10/10 20:25:00 As mentioned in the blink patch, use a pointer, no

sivag 2014/10/27 13:34:52 Done.

virtual blink::WebGraphicsContext3DProvider*

createSharedOffscreenGraphicsContext3DProvider();

virtual blink::WebCompositorSupport* compositorSupport();

« no previous file with comments | « no previous file | content/renderer/renderer_blink_platform_impl.cc » ('j') | content/renderer/renderer_blink_platform_impl.cc » ('J')