Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 645603003: app_list_folder_item.h: Fix typedefs and includes (ahead of refactor). (Closed)

Created:
6 years, 2 months ago by Matt Giuca
Modified:
6 years, 2 months ago
Reviewers:
*calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

app_list_folder_item.h: Fix typedefs and includes (ahead of refactor). - Removed the 'Rects' typedef. Should not be exporting this; it will cause trouble when refactoring. - Forward-declare gfx::Rect instead of including it. - Added missing include in app_list_controller_delegate.cc (exposed by removing the include in app_list_folder_item.h). BUG=425444 Committed: https://crrev.com/160798857aaddc953e37526af7fa5b1859dad32d Cr-Commit-Position: refs/heads/master@{#300838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list_folder_item.h View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/app_list/app_list_folder_item.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ui/app_list/views/apps_container_view.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/app_list/views/apps_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Matt Giuca
6 years, 2 months ago (2014-10-21 06:56:22 UTC) #3
calamity
lgtm
6 years, 2 months ago (2014-10-23 02:48:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645603003/1
6 years, 2 months ago (2014-10-23 04:14:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 05:02:35 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 05:03:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/160798857aaddc953e37526af7fa5b1859dad32d
Cr-Commit-Position: refs/heads/master@{#300838}

Powered by Google App Engine
This is Rietveld 408576698