Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Side by Side Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 645573004: fix suggestions in class body and more common tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.completion.computer.dart.local; 5 library services.completion.computer.dart.local;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/protocol.dart' as protocol show Element, 9 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
10 ElementKind; 10 ElementKind;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 } 78 }
79 }); 79 });
80 } 80 }
81 } 81 }
82 } 82 }
83 }); 83 });
84 visitNode(node); 84 visitNode(node);
85 } 85 }
86 86
87 @override 87 @override
88 Future<bool> visitCombinator(Combinator node) { 88 visitCombinator(Combinator node) {
89 // Handled by ImportedComputer 89 // Handled by ImportedComputer
90 } 90 }
91 91
92 @override 92 @override
93 visitCascadeExpression(CascadeExpression node) { 93 visitCascadeExpression(CascadeExpression node) {
94 Expression target = node.target; 94 Expression target = node.target;
95 // This computer handles the expression 95 // This computer handles the expression
96 // while InvocationComputer handles the cascade selector 96 // while InvocationComputer handles the cascade selector
97 if (target != null && request.offset <= target.end) { 97 if (target != null && request.offset <= target.end) {
98 visitNode(node); 98 visitNode(node);
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 if (name == null || name.length <= 0) { 481 if (name == null || name.length <= 0) {
482 return DYNAMIC; 482 return DYNAMIC;
483 } 483 }
484 TypeArgumentList typeArgs = type.typeArguments; 484 TypeArgumentList typeArgs = type.typeArguments;
485 if (typeArgs != null) { 485 if (typeArgs != null) {
486 //TODO (danrubel) include type arguments 486 //TODO (danrubel) include type arguments
487 } 487 }
488 return name; 488 return name;
489 } 489 }
490 } 490 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698