Issue 645563002: use real pdfdevice behind SkDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 645563002: use real pdfdevice behind SkDocument (Closed)

Created:
6 years, 2 months ago by reed1

Modified:
6 years, 1 month ago

Reviewers:
hal.canary

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

use real pdfdevice behind SkDocument BUG=skia: TBR=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/5867736b08d3689356b49f505bcf748c2194a0bc

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/doc/SkDocument_PDF.cpp	View		3 chunks	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645563002/1

6 years, 2 months ago (2014-10-09 12:22:20 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 5867736b08d3689356b49f505bcf748c2194a0bc

6 years, 2 months ago (2014-10-09 12:30:14 UTC) #3

hal.canary

6 years, 1 month ago (2014-11-02 00:45:29 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/645563002/diff/1/src/doc/SkDocument_PDF.cpp
File src/doc/SkDocument_PDF.cpp (right):

https://codereview.chromium.org/645563002/diff/1/src/doc/SkDocument_PDF.cpp#n...
src/doc/SkDocument_PDF.cpp:32: const SkRect& trimBox) SK_OVERRIDE {
You are dropping trimBox on the floor.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages