Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 645533003: Use hash map to look for objects in the root array when serializing. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
mvstanton, Erik Corry
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use hash map to look for objects in the root array when serializing. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24826

Patch Set 1 #

Patch Set 2 : make use of the hash map more often. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -253 lines) Patch
M src/compiler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 1 15 chunks +165 lines, -101 lines 2 comments Download
M src/serialize.cc View 1 20 chunks +141 lines, -145 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Yang
6 years, 2 months ago (2014-10-21 14:00:06 UTC) #1
mvstanton
I really like the new classes. LGTM. https://codereview.chromium.org/645533003/diff/20001/src/serialize.h File src/serialize.h (right): https://codereview.chromium.org/645533003/diff/20001/src/serialize.h#newcode265 src/serialize.h:265: DisallowHeapAllocation no_allocation_; ...
6 years, 2 months ago (2014-10-23 08:02:15 UTC) #2
Yang
Committed patchset #2 (id:20001) manually as 24826 (presubmit successful).
6 years, 2 months ago (2014-10-23 08:43:29 UTC) #3
Erik Corry
6 years, 2 months ago (2014-10-23 12:57:15 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/645533003/diff/20001/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/645533003/diff/20001/src/serialize.cc#newcode...
src/serialize.cc:1671: // ones in the root array that are never in new space.
I think now this is _all_ the entries in the root array that are _not currently_
in new space.

Powered by Google App Engine
This is Rietveld 408576698