Clean up test_runner Command subclass hash/equality.

tools/testing/dart/utils.dart

Index: tools/testing/dart/utils.dart
diff --git a/tools/testing/dart/utils.dart b/tools/testing/dart/utils.dart
index b5b5f879b7dfbd9a3b4f892ee0eed782598aba63..ae5813854d7d68d16b2138c609edbb5b6454837a 100644
--- a/tools/testing/dart/utils.dart
+++ b/tools/testing/dart/utils.dart
@@ -218,7 +218,7 @@ class Locations {
         },
         'ie10': const {
           'windows': 'C:\\Program Files\\Internet Explorer\\iexplore.exe'
-        }, 
+        },
         'ie11': const {
           'windows': 'C:\\Program Files\\Internet Explorer\\iexplore.exe'
         }};
@@ -251,12 +251,15 @@ class HashCodeBuilder {
   }
 
   void addJson(Object object) {

[Bill Hesse, 2014/10/09 12:03:50]

This class is only used for test_runner.dart hashcode/equality for Command
subclasses, so we want to allow URIs and to hash equal maps identically.

-    if (object == null || object is num || object is String) {
+    if (object == null || object is num || object is String || object is Uri) {
       add(object);
     } else if (object is List) {
       object.forEach(addJson);
     } else if (object is Map) {
-      object.forEach((k, v) { addJson(k); addJson(value); });
+      for (var key in object.keys.toList()..sort()) {
+        addJson(key);
+        addJson(object[key]);
+      }
     } else {
       throw new Exception("Can't build hashcode for non json-like object "
           "(${object.runtimeType})");