Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: sky/engine/core/events/EventTarget.cpp

Issue 645513006: Remove beforeunload events. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/events/Event.cpp ('k') | sky/engine/core/events/EventTypeNames.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/events/EventTarget.cpp
diff --git a/sky/engine/core/events/EventTarget.cpp b/sky/engine/core/events/EventTarget.cpp
index 17f7b0b4ea16e4c49d6a89b5717545f1f9621080..c4ff0cb7d3f5df269d1d325f517acdb58fa79820 100644
--- a/sky/engine/core/events/EventTarget.cpp
+++ b/sky/engine/core/events/EventTarget.cpp
@@ -289,10 +289,7 @@ void EventTarget::fireEventListeners(Event* event, EventTargetData* d, EventList
// index |size|, so iterating up to (but not including) |size| naturally excludes
// new event listeners.
- if (event->type() == EventTypeNames::beforeunload) {
- if (LocalDOMWindow* executingWindow = this->executingWindow())
- UseCounter::count(executingWindow->document(), UseCounter::DocumentBeforeUnloadFired);
- } else if (event->type() == EventTypeNames::unload) {
+ if (event->type() == EventTypeNames::unload) {
if (LocalDOMWindow* executingWindow = this->executingWindow())
UseCounter::count(executingWindow->document(), UseCounter::DocumentUnloadFired);
} else if (event->type() == EventTypeNames::DOMFocusIn || event->type() == EventTypeNames::DOMFocusOut) {
« no previous file with comments | « sky/engine/core/events/Event.cpp ('k') | sky/engine/core/events/EventTypeNames.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698