Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 645513004: [DevTools] Report error in debug mode from promise with stack (Closed)

Created:
6 years, 2 months ago by kozyatinskiy1
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DevTools] Report error in debug mode from promise with stack R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M Source/devtools/front_end/Runtime.js View 1 chunk +15 lines, -2 lines 0 comments Download
M Source/devtools/front_end/common/utilities.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/externs.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
kozyatinskiy1
Vsevolod, please take a look.
6 years, 2 months ago (2014-10-23 14:05:42 UTC) #1
vsevik
We should report error message as well.
6 years, 2 months ago (2014-10-23 15:07:24 UTC) #2
kozyatinskiy1
On 2014/10/23 15:07:24, vsevik wrote: > We should report error message as well. I can ...
6 years, 2 months ago (2014-10-23 15:11:59 UTC) #3
vsevik
lgtm
6 years, 2 months ago (2014-10-23 15:18:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645513004/1
6 years, 2 months ago (2014-10-23 15:19:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 16:21:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184282

Powered by Google App Engine
This is Rietveld 408576698