Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: Source/core/fetch/ResourceLoadPriorityOptimizer.cpp

Issue 645513003: Use C++11 range-based loop in core/fetch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: mike's comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/fetch/ResourceLoadPriorityOptimizer.cpp
diff --git a/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp b/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp
index 06bf4db45e6d619512dd6d3fa606540fa384557c..ccae349353b12b74acf05b23fc00450b64d64609 100644
--- a/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp
+++ b/Source/core/fetch/ResourceLoadPriorityOptimizer.cpp
@@ -83,11 +83,9 @@ void ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities()
m_imageResources.clear();
Vector<RenderObject*> objectsToRemove;
- for (RenderObjectSet::iterator it = m_objects.begin(); it != m_objects.end(); ++it) {
- RenderObject* obj = *it;
- if (!obj->updateImageLoadingPriorities()) {
- objectsToRemove.append(obj);
- }
+ for (const auto& renderObject : m_objects) {
+ if (!renderObject->updateImageLoadingPriorities())
+ objectsToRemove.append(renderObject);
}
m_objects.removeAll(objectsToRemove);
@@ -96,13 +94,13 @@ void ResourceLoadPriorityOptimizer::updateAllImageResourcePriorities()
void ResourceLoadPriorityOptimizer::updateImageResourcesWithLoadPriority()
{
- for (ImageResourceMap::iterator it = m_imageResources.begin(); it != m_imageResources.end(); ++it) {
- ResourceLoadPriority priority = it->value->status == Visible ?
+ for (const auto& resource : m_imageResources) {
+ ResourceLoadPriority priority = resource.value->status == Visible ?
ResourceLoadPriorityLow : ResourceLoadPriorityVeryLow;
- if (priority != it->value->imageResource->resourceRequest().priority()) {
- it->value->imageResource->mutableResourceRequest().setPriority(priority, it->value->screenArea);
- it->value->imageResource->didChangePriority(priority, it->value->screenArea);
+ if (priority != resource.value->imageResource->resourceRequest().priority()) {
+ resource.value->imageResource->mutableResourceRequest().setPriority(priority, resource.value->screenArea);
+ resource.value->imageResource->didChangePriority(priority, resource.value->screenArea);
}
}
m_imageResources.clear();

Powered by Google App Engine
This is Rietveld 408576698