Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: Source/core/fetch/MemoryCache.cpp

Issue 645513003: Use C++11 range-based loop in core/fetch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/fetch/MemoryCache.cpp
diff --git a/Source/core/fetch/MemoryCache.cpp b/Source/core/fetch/MemoryCache.cpp
index 824a779a56472befab8403e84bbd7c3424ba06a4..71b03936a16a721a5f4fb360f0e180cd82e50cdf 100644
--- a/Source/core/fetch/MemoryCache.cpp
+++ b/Source/core/fetch/MemoryCache.cpp
@@ -62,10 +62,8 @@ PassOwnPtrWillBeRawPtr<MemoryCache> replaceMemoryCacheForTesting(PassOwnPtrWillB
{
#if ENABLE(OILPAN)
// Move m_liveResources content to keep Resource objects alive.
- for (HeapHashSet<Member<Resource> >::iterator i = memoryCache()->m_liveResources.begin();
- i != memoryCache()->m_liveResources.end();
- ++i) {
- cache->m_liveResources.add(*i);
+ for (const auto& resource : memoryCache()->m_liveResources) {
Mike West 2014/10/17 10:38:49 Nit: Drop the {} for one-liners.
riju_ 2014/10/17 18:36:48 Done.
+ cache->m_liveResources.add(resource);
}
memoryCache()->m_liveResources.clear();
#else
@@ -616,9 +614,8 @@ void MemoryCache::TypeStatistic::addResource(Resource* o)
MemoryCache::Statistics MemoryCache::getStatistics()
{
Statistics stats;
- ResourceMap::iterator e = m_resources.end();
- for (ResourceMap::iterator i = m_resources.begin(); i != e; ++i) {
- Resource* resource = i->value->m_resource.get();
+ for (const auto& resourceIter : m_resources) {
+ Resource* resource = resourceIter.value->m_resource.get();
switch (resource->type()) {
case Resource::Image:
stats.images.addResource(resource);

Powered by Google App Engine
This is Rietveld 408576698