Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 645443003: Move parts of core/dom to C++11 (Closed)

Created:
6 years, 2 months ago by kenneth.r.christiansen
Modified:
6 years, 2 months ago
Reviewers:
Mike West, Mikhail
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Move parts of core/dom to C++11 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184175

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -158 lines) Patch
M Source/core/dom/Document.h View 21 chunks +30 lines, -30 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 20 chunks +46 lines, -71 lines 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentOrderedList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentParser.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/dom/DocumentSupplementable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/Element.cpp View 17 chunks +27 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Mike West
LGTM % nit. https://codereview.chromium.org/645443003/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/645443003/diff/1/Source/core/dom/Document.cpp#newcode3776 Source/core/dom/Document.cpp:3776: if (!m_ranges.isEmpty()) { Nit: Doesn't the ...
6 years, 2 months ago (2014-10-21 18:51:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645443003/20001
6 years, 2 months ago (2014-10-22 06:40:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33003)
6 years, 2 months ago (2014-10-22 09:37:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645443003/20001
6 years, 2 months ago (2014-10-22 10:15:06 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 12:22:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184175

Powered by Google App Engine
This is Rietveld 408576698