Issue 64543004: Disable concurrent osr when concurrent recompilation is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64543004: Disable concurrent osr when concurrent recompilation is disabled. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Disable concurrent osr when concurrent recompilation is disabled. Also introduce a flag for a quick check that concurrency is on. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17570

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : git cl dcommit #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
M	src/isolate.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/optimizing-compiler-thread.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/v8.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/64543004/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/64543004/diff/1/src/flag-definitions.h#newcode337 src/flag-definitions.h:337: DEFINE_bool(verify_concurrency, false, As discussed, the existing ...

7 years, 1 month ago (2013-11-07 16:13:20 UTC) #2

Yang

7 years, 1 month ago (2013-11-07 16:25:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r17570 (presubmit successful).

Expand Messages | Collapse Messages