Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 645423003: Make Mojo's NetAddress use local endianness for the port. (Closed)

Created:
6 years, 2 months ago by brettw
Modified:
6 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Mojo's NetAddress use local endianness for the port. Previously the port was specified in network byte order, but this is both unnecessary and doesn't make sense for some languages. This patch changes the port number to just be a regular number on the local machine. Committed: https://crrev.com/cb1bb110c6b8223b50cce07e43204149e4f92219 Cr-Commit-Position: refs/heads/master@{#299728}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M mojo/services/network/net_address_type_converters.cc View 1 2 3 chunks +4 lines, -10 lines 0 comments Download
M mojo/services/public/interfaces/network/net_address.mojom View 1 1 chunk +8 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/udp_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
6 years, 2 months ago (2014-10-15 16:31:20 UTC) #2
yzshen1
LGTM https://codereview.chromium.org/645423003/diff/20001/mojo/services/network/net_address_type_converters.cc File mojo/services/network/net_address_type_converters.cc (right): https://codereview.chromium.org/645423003/diff/20001/mojo/services/network/net_address_type_converters.cc#newcode7 mojo/services/network/net_address_type_converters.cc:7: #include "base/sys_byteorder.h" This is not needed anymore
6 years, 2 months ago (2014-10-15 17:24:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645423003/40001
6 years, 2 months ago (2014-10-15 17:48:03 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-15 18:38:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 18:39:35 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb1bb110c6b8223b50cce07e43204149e4f92219
Cr-Commit-Position: refs/heads/master@{#299728}

Powered by Google App Engine
This is Rietveld 408576698