Issue 645393005: minidump: Rename MinidumpCrashpadModuleInfoWriter files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 645393005: minidump: Rename MinidumpCrashpadModuleInfoWriter files (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

minidump: Rename MinidumpCrashpadModuleInfoWriter files. The classes were renamed in response to https://codereview.chromium.org/675803002/diff/1/minidump/minidump_extensions.h#newcode334, but the files were not. TEST=minidump_test \ MinidumpCrashpadInfoWriter.*:MinidumpModuleCrashpadInfoWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3f48f6d79869cfbd7fc85bbe4c49729b1d6a04fc

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -538 lines)			Patch
M	minidump/minidump.gyp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	minidump/minidump_crashpad_info_writer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	minidump/minidump_crashpad_info_writer_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	minidump/minidump_crashpad_module_writer.h	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	minidump/minidump_crashpad_module_writer.cc	View	1 chunk	+0 lines, -160 lines	0 comments	Download
D	minidump/minidump_crashpad_module_writer_test.cc	View	1 chunk	+0 lines, -266 lines	0 comments	Download
A +	minidump/minidump_module_crashpad_info_writer.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	minidump/minidump_module_crashpad_info_writer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	minidump/minidump_module_crashpad_info_writer_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Robert Sesek

LGTM. I should have realized that review was easier to do than it should have ...

6 years, 1 month ago (2014-10-24 18:58:01 UTC) #3

Mark Mentovai

6 years, 1 month ago (2014-10-24 18:58:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3f48f6d79869cfbd7fc85bbe4c49729b1d6a04fc (presubmit successful).