Split RmTreeAndMkDir into two separate functions (refactoring).

Split RmTreeAndMkDir into two separate functions (refactoring).

The function RmTreeAndMkDir did two different things depending on a boolean flag that was passed to it.

This CL splits it into two functions so that each function only takes one argument and does one thing.

BUG=

Committed: https://crrev.com/902242f397508c4617f8cdbb2034b3d896b467cc
Cr-Commit-Position: refs/heads/master@{#299815}

[qyearsley, 2014-10-13 18:14:02]

qyearsley@chromium.org changed reviewers:
+ prasadv@chromium.org

[RobertoCN, 2014-10-14 18:31:33]

robertocn@chromium.org changed reviewers:
+ robertocn@chromium.org

[RobertoCN, 2014-10-14 18:31:34]

https://codereview.chromium.org/645383002/diff/130001/tools/auto_bisect/bisec...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/645383002/diff/130001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression.py:2917: if
RemakeDirectoryTree(os.path.join('build', build_type)):
Wouldn't an 'and' look better here as opposed to the nested if blocks?

[qyearsley, 2014-10-14 18:36:26]

https://codereview.chromium.org/645383002/diff/130001/tools/auto_bisect/bisec...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/645383002/diff/130001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression.py:2917: if
RemakeDirectoryTree(os.path.join('build', build_type)):
On 2014/10/14 18:31:34, robertocn wrote:
> Wouldn't an 'and' look better here as opposed to the nested if blocks?

IMO, "and" would definitely be better here if the two conditions were a bit
shorter, but if the condition takes up two lines, it's not necessarily more
readable than the nested "if".

What about:

out_dir = os.path.join('out', build_type)
build_dir = os.path.join('build', build_type)
return RemakeDirectoryTree(out_dir) and RemakeDirectoryTree(build_dir)

[RobertoCN, 2014-10-14 19:13:14]

On 2014/10/14 18:36:26, qyearsley wrote:
>
https://codereview.chromium.org/645383002/diff/130001/tools/auto_bisect/bisec...
> File tools/auto_bisect/bisect_perf_regression.py (right):
> 
>
https://codereview.chromium.org/645383002/diff/130001/tools/auto_bisect/bisec...
> tools/auto_bisect/bisect_perf_regression.py:2917: if
> RemakeDirectoryTree(os.path.join('build', build_type)):
> On 2014/10/14 18:31:34, robertocn wrote:
> > Wouldn't an 'and' look better here as opposed to the nested if blocks?
> 
> IMO, "and" would definitely be better here if the two conditions were a bit
> shorter, but if the condition takes up two lines, it's not necessarily more
> readable than the nested "if".
> 
> What about:
> 
> out_dir = os.path.join('out', build_type)
> build_dir = os.path.join('build', build_type)
> return RemakeDirectoryTree(out_dir) and RemakeDirectoryTree(build_dir)

That a lot easier to read.

LGTM

[prasadv, 2014-10-16 00:14:01]

lgtm

[qyearsley, 2014-10-16 00:35:12]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645383002/170001

[commit-bot: I haz the power, 2014-10-16 01:57:32]

Committed patchset #5 (id:170001)

[commit-bot: I haz the power, 2014-10-16 01:58:02]

Patchset 5 (id:??) landed as
https://crrev.com/902242f397508c4617f8cdbb2034b3d896b467cc
Cr-Commit-Position: refs/heads/master@{#299815}