Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 645363006: Don't send NewFrameProxy for top-level remote frames (Closed)

Created:
6 years, 2 months ago by alexmos
Modified:
6 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't send NewFrameProxy for top-level remote frames. If site A embeds a frame for site B, the process for B needs to create a remote frame to represent the top-level frame A. Currently, this is done when RenderFrameHostManager::CreateRenderFrame sends a ViewMsg_New to process B to create a swapped-out RenderView. However, after initializing the new view, CreateRenderFrame also sends a NewFrameProxy message, which isn't necessary because the remote frame has already been created. Note that nothing actually happens on the renderer side due to another bug with sending NewFrameProxy (crbug.com/423538). This CL removes the call to InitRenderFrameProxy which sends the extra NewFrameProxy. We only need to send NewFrameProxy messages for subframes, and we should never hit this path for subframes with swapped_out being true (there's a CHECK on top of RFHM::CreateRenderFrame that ensures this). BUG=423567 Committed: https://crrev.com/28d4362169d043400a389e70b4744b7e74b4559c Cr-Commit-Position: refs/heads/master@{#299970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
lutei777
6 years, 2 months ago (2014-10-15 23:29:10 UTC) #2
alexmos
Nasko, could you please review this CL?
6 years, 2 months ago (2014-10-16 16:48:20 UTC) #5
nasko
LGTM
6 years, 2 months ago (2014-10-16 18:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645363006/1
6 years, 2 months ago (2014-10-16 20:21:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 20:35:42 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 20:36:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28d4362169d043400a389e70b4744b7e74b4559c
Cr-Commit-Position: refs/heads/master@{#299970}

Powered by Google App Engine
This is Rietveld 408576698