Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 645363005: Fix for memory leaks in SpeechRecognitionAudioSinkTest (Closed)

Created:
6 years, 2 months ago by burnik
Modified:
6 years, 2 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Several memory leaks in unit test: SpeechRecognitionAudioSinkTest. Due to uninitialized memory. This CL is fixing the issue. BUG=408940, 422164, 422472 TEST=Memory bot for content_unittests Committed: https://crrev.com/0aef15554835f531e82fc28fb5823a64b4e3e088 Cr-Commit-Position: refs/heads/master@{#299277}

Patch Set 1 #

Patch Set 2 : Remove suppressions #

Patch Set 3 : Init bus and data to zero #

Patch Set 4 : Rebase and clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -55 lines) Patch
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 1 chunk +0 lines, -34 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
burnik
Remove suppressions
6 years, 2 months ago (2014-10-11 21:40:08 UTC) #1
burnik
Init bus and data to zero
6 years, 2 months ago (2014-10-11 22:00:34 UTC) #2
burnik
Rebase and clean up
6 years, 2 months ago (2014-10-12 18:47:24 UTC) #3
burnik
A few more memory leaks according to: https://code.google.com/p/chromium/issues/detail?id=422472 Should now be fixed by this CL.
6 years, 2 months ago (2014-10-12 21:08:36 UTC) #5
no longer working on chromium
On 2014/10/12 21:08:36, burnik wrote: > A few more memory leaks according to: > https://code.google.com/p/chromium/issues/detail?id=422472 ...
6 years, 2 months ago (2014-10-13 09:10:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645363005/130001
6 years, 2 months ago (2014-10-13 09:52:11 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:130001)
6 years, 2 months ago (2014-10-13 10:03:05 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 10:03:40 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0aef15554835f531e82fc28fb5823a64b4e3e088
Cr-Commit-Position: refs/heads/master@{#299277}

Powered by Google App Engine
This is Rietveld 408576698