Source/platform/fonts/shaping/HarfBuzzShaper.h - Issue 645363003: Consolidate most simple vs. complex Font methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 645363003: Consolidate most simple vs. complex Font methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: minor cleanup Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/shaping/HarfBuzzShaper.h

diff --git a/Source/platform/fonts/shaping/HarfBuzzShaper.h b/Source/platform/fonts/shaping/HarfBuzzShaper.h

index 10e528ef498c5d3f2569870a8ddff9428d91bd37..38bcfb97f710b8553919c2b9b88176a84c829ede 100644

--- a/Source/platform/fonts/shaping/HarfBuzzShaper.h

+++ b/Source/platform/fonts/shaping/HarfBuzzShaper.h

@@ -46,7 +46,7 @@

namespace blink {

class Font;

-class GlyphBufferWithOffsets;

+class GlyphBuffer;

class SimpleFontData;

class HarfBuzzShaper final {

@@ -129,7 +129,7 @@ private:

bool createHarfBuzzRuns();

bool shapeHarfBuzzRuns();

bool fillGlyphBuffer(GlyphBuffer*);

- void fillGlyphBufferFromHarfBuzzRun(GlyphBufferWithOffsets*, HarfBuzzRun*, float& carryAdvance);

+ void fillGlyphBufferFromHarfBuzzRun(GlyphBuffer*, HarfBuzzRun*, float& carryAdvance);

void fillGlyphBufferForTextEmphasis(GlyphBuffer*, HarfBuzzRun* currentRun);

void setGlyphPositionsForHarfBuzzRun(HarfBuzzRun*, hb_buffer_t*);

void addHarfBuzzRun(unsigned startCharacter, unsigned endCharacter, const SimpleFontData*, UScriptCode);