Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: Source/platform/image-encoders/skia/WEBPImageEncoder.cpp

Issue 645333002: [Android] ImageBuffer toDataURL("image/webp") has RGBA pixel input (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/image-encoders/skia/WEBPImageEncoder.cpp
diff --git a/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp b/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp
index e52a6848809ed6e893f09811758ac0ee9f77cc00..fbded265fc6080f184416957bfefae9a97629457 100644
--- a/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp
+++ b/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp
@@ -83,6 +83,14 @@ template <bool Premultiplied> inline bool importPictureRGBX(const unsigned char*
return rgbPictureImport(pixels, Premultiplied, &WebPPictureImportRGBX, &WebPPictureImportRGB, picture);
}
+static bool platformPremultipliedImportPicture(const unsigned char* pixels, WebPPicture* picture)
+{
+ if (SK_B32_SHIFT) // Android
+ return importPictureRGBX<true>(pixels, picture);
+
+ return importPictureBGRX<true>(pixels, picture);
+}
+
static bool encodePixels(IntSize imageSize, const unsigned char* pixels, bool premultiplied, int quality, Vector<unsigned char>* output)
{
WebPConfig config;
@@ -100,7 +108,7 @@ static bool encodePixels(IntSize imageSize, const unsigned char* pixels, bool pr
return false;
picture.height = imageSize.height();
- if (premultiplied && !importPictureBGRX<true>(pixels, &picture))
+ if (premultiplied && !platformPremultipliedImportPicture(pixels, &picture))
return false;
if (!premultiplied && !importPictureRGBX<false>(pixels, &picture))
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698