Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: components/omnibox/omnibox_field_trial.cc

Issue 645303003: Parametrize Suggest polling strategy and delay. Also add a parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/omnibox_field_trial.cc
diff --git a/components/omnibox/omnibox_field_trial.cc b/components/omnibox/omnibox_field_trial.cc
index 96adb803263731c2b3bc50e7b913c7a362dee699..da1d402c5967b844e4364f18000dae32626cff79 100644
--- a/components/omnibox/omnibox_field_trial.cc
+++ b/components/omnibox/omnibox_field_trial.cc
@@ -336,6 +336,28 @@ bool OmniboxFieldTrial::DisplayHintTextWhenPossible() {
kDisplayHintTextWhenPossibleRule) == "true";
}
+bool OmniboxFieldTrial::DisableResultsCaching() {
+ return variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kDisableResultsCachingRule) == "true";
+}
+
+void OmniboxFieldTrial::GetSuggestPollingStrategy(bool* from_last_keystroke,
+ int* polling_delay_ms) {
+ *from_last_keystroke = variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kMeasureSuggestPollingDelayFromLastKeystrokeRule) == "true";
+
+ const std::string& polling_delay_string = variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName,
+ kSuggestPollingDelayMsRule);
+ if (polling_delay_string.empty() ||
+ !base::StringToInt(polling_delay_string, polling_delay_ms) ||
+ (*polling_delay_ms <= 0)) {
+ *polling_delay_ms = kDefaultMinimumTimeBetweenSuggestQueriesMs;
+ }
+}
+
const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
"OmniboxBundledExperimentV1";
const char OmniboxFieldTrial::kShortcutsScoringMaxRelevanceRule[] =
@@ -355,6 +377,13 @@ const char OmniboxFieldTrial::kAddUWYTMatchEvenIfPromotedURLsRule[] =
"AddUWYTMatchEvenIfPromotedURLs";
const char OmniboxFieldTrial::kDisplayHintTextWhenPossibleRule[] =
"DisplayHintTextWhenPossible";
+const char OmniboxFieldTrial::kDisableResultsCachingRule[] =
+ "DisableResultsCaching";
+const char
+OmniboxFieldTrial::kMeasureSuggestPollingDelayFromLastKeystrokeRule[] =
+ "MeasureSuggestPollingDelayFromLastKeystroke";
+const char OmniboxFieldTrial::kSuggestPollingDelayMsRule[] =
+ "SuggestPollingDelayMs";
const char OmniboxFieldTrial::kHUPNewScoringEnabledParam[] =
"HUPExperimentalScoringEnabled";
@@ -371,6 +400,9 @@ const char OmniboxFieldTrial::kHUPNewScoringVisitedCountHalfLifeTimeParam[] =
const char OmniboxFieldTrial::kHUPNewScoringVisitedCountScoreBucketsParam[] =
"VisitedCountScoreBuckets";
+// static
+int OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs = 100;
+
// Background and implementation details:
//
// Each experiment group in any field trial can come with an optional set of

Powered by Google App Engine
This is Rietveld 408576698