Parametrize Suggest polling strategy and delay. Also add a parameter

components/omnibox/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 263 matching lines @@
   // ---------------------------------------------------------
   // For the DisplayHintTextWhenPossible experiment that's part of the
   // bundled omnibox field trial.
 
   // Returns true if the omnibox should display hint text (Search
   // <search engine> or type URL) when possible (i.e., the omnibox
   // is otherwise non-empty).
   static bool DisplayHintTextWhenPossible();
 
   // ---------------------------------------------------------
+  // For SearchProvider related experiments.
+
+  // Returns true if the search provider should not be caching results.
+  static bool DisableResultsCaching();
+
+  // Returns how the search provider should poll Suggest. Currently, we support
+  // measuring polling delay from the last keystroke or last suggest request.
+  static void GetSuggestPollingStrategy(bool* from_last_keystroke,
+                                        int* polling_delay_ms);
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kDisableInliningRule[];
   static const char kAnswersInSuggestRule[];
   static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
   static const char kDisplayHintTextWhenPossibleRule[];
+  static const char kDisableResultsCachingRule[];
+  static const char kMeasureSuggestPollingDelayFromLastKeystrokeRule[];
+  static const char kSuggestPollingDelayMsRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
 
+  // The amount of time to wait before sending a new suggest request after the
+  // previous one.  Non-const because some unittests modify this value.

[Mark P, 2014/10/22 20:33:07]

one
->
one unless overridden by a field trial parameter

[Bart N., 2014/10/22 22:04:56]

Done.

+  static int kMinimumTimeBetweenSuggestQueriesMs;

[Mark P, 2014/10/22 20:33:07]

add Default in this name somewhere

[Bart N., 2014/10/22 22:04:57]

Done.

+
  private:
   friend class OmniboxFieldTrialTest;
 
   // The bundled omnibox experiment comes with a set of parameters
   // (key-value pairs).  Each key indicates a certain rule that applies in
   // a certain context.  The value indicates what the consequences of
   // applying the rule are.  For example, the value of a SearchHistory rule
   // in the context of a search results page might indicate that we should
   // prevent search history matches from inlining.
   //
   // This function returns the value associated with the |rule| that applies
   // in the current context (which currently consists of |page_classification|
   // and whether Instant Extended is enabled).  If no such rule exists in the
   // current context, fall back to the rule in various wildcard contexts and
   // return its value if found.  If the rule remains unfound in the global
   // context, returns the empty string.  For more details, including how we
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_