Parametrize Suggest polling strategy and delay. Also add a parameter

components/omnibox/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 263 matching lines @@
   // ---------------------------------------------------------
   // For the DisplayHintTextWhenPossible experiment that's part of the
   // bundled omnibox field trial.
 
   // Returns true if the omnibox should display hint text (Search
   // <search engine> or type URL) when possible (i.e., the omnibox
   // is otherwise non-empty).
   static bool DisplayHintTextWhenPossible();
 
   // ---------------------------------------------------------
+  // For Search Provider related experiments.

[Mark P, 2014/10/21 21:28:22]

nit: SearchProvider

[Bart N., 2014/10/22 01:19:08]

Done.

+
+  // Returns true if the search provider should not be caching results.
+  static bool DisableResultsCaching();
+
+  // Returns how the search provider should poll Suggest. Currently, we support
+  // measuring polling delay since the last keystroke or last suggest request.
+  static void GetSuggestPollingStrategy(bool* since_the_last_request,
+                                        int* polling_delay_ms);
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kDisableInliningRule[];
   static const char kAnswersInSuggestRule[];
   static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
   static const char kDisplayHintTextWhenPossibleRule[];
+  // Search Provider experiments.

[Mark P, 2014/10/21 21:28:22]

nit: comment unnecessary
(we omit all similar comments in this list of rules)

[Bart N., 2014/10/22 01:19:08]

Done.

+  static const char kDisableResultsCachingRule[];
+  static const char kSuggestPollingDelaySinceTheLastRequestRule[];

[Mark P, 2014/10/21 21:28:22]

nit: I'd prefer this rule name had a verb such as
kMeasureSuggestPollingDelayFromLastRequestRule

[Bart N., 2014/10/22 01:19:08]

Done.

+  static const char kSuggestPollingDelayMsRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
 
@@ skipping 16 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_