Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 645263002: Implementing direction_of_improvement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding missing option from command-line building logic. Improved error message. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index aa3251dcec58a0947703afd4c0484fd6a3fa0f12..344e36b1691b1aa0e2da68852bcd022c5783a0ea 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -207,6 +207,9 @@ def _CreateBisectOptionsFromConfig(config):
if config.has_key('goma_dir'):
opts_dict['goma_dir'] = config['goma_dir']
+ if config.has_key('improvement_direction'):
+ opts_dict['improvement_direction'] = int(config['improvement_direction'])
+
opts_dict['build_preference'] = 'ninja'
opts_dict['output_buildbot_annotations'] = True
@@ -403,6 +406,9 @@ def _RunBisectionScript(
if config.has_key('bisect_mode'):
cmd.extend(['--bisect_mode', config['bisect_mode']])
+ if config.has_key('improvement_direction'):
+ cmd.extend(['-d', config['improvement_direction']])
+
cmd.extend(['--build_preference', 'ninja'])
if '--browser=cros' in config['command']:
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698