tools/gn/input_file_manager.h - Issue 645253002: GN: Store parse error messages (so they aren't dropped due to races)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/input_file_manager.h

Issue 645253002: GN: Store parse error messages (so they aren't dropped due to races) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/input_file_manager.h

diff --git a/tools/gn/input_file_manager.h b/tools/gn/input_file_manager.h

index 82b3cc57e6a252d9c04496172578d4d973016d2f..0a32f9ea804c4871285a6d8bcc8087e4046f8f8b 100644

--- a/tools/gn/input_file_manager.h

+++ b/tools/gn/input_file_manager.h

@@ -117,6 +117,7 @@ class InputFileManager : public base::RefCountedThreadSafe<InputFileManager> {

// Null before the file is loaded or if loading failed.

scoped_ptr<ParseNode> parsed_root;

+ scoped_ptr<Err> parse_error;

brettw 2014/10/14 17:13:09 You should be able to make this a raw "Err" object

cjhopman 2014/10/16 18:26:02 Done.

};

virtual ~InputFileManager();

« no previous file with comments | « no previous file | tools/gn/input_file_manager.cc » ('j') | tools/gn/input_file_manager.cc » ('J')