GN: Store parse error messages (so they aren't dropped due to races)

GN: Store parse error messages (so they aren't dropped due to races)

Bad error messages remind me of working with gyp.

This change just stores the parser error in the InputFileData so that we
can actually report a useful error message from whichever thread first
reports an error.

Committed: https://crrev.com/86e95b3ce8e0e83f9d011e285b0a97313125cf1e
Cr-Commit-Position: refs/heads/master@{#299953}

[cjhopman, 2014-10-13 18:08:41]

cjhopman@chromium.org changed reviewers:
+ brettw@chromium.org

[cjhopman, 2014-10-13 18:08:41]

brettw: *

[brettw, 2014-10-14 17:13:09]

lgtm

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager.cc
File tools/gn/input_file_manager.cc (right):

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager....
tools/gn/input_file_manager.cc:222: if (!data->parsed_root) {
Remove {}

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager.h
File tools/gn/input_file_manager.h (right):

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager....
tools/gn/input_file_manager.h:120: scoped_ptr<Err> parse_error;
You should be able to make this a raw "Err" object. Since an err has a "no
error" state on it (the default constructor).

[cjhopman, 2014-10-16 18:26:02]

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager.cc
File tools/gn/input_file_manager.cc (right):

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager....
tools/gn/input_file_manager.cc:222: if (!data->parsed_root) {
On 2014/10/14 17:13:09, brettw wrote:
> Remove {}

Done.

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager.h
File tools/gn/input_file_manager.h (right):

https://codereview.chromium.org/645253002/diff/1/tools/gn/input_file_manager....
tools/gn/input_file_manager.h:120: scoped_ptr<Err> parse_error;
On 2014/10/14 17:13:09, brettw wrote:
> You should be able to make this a raw "Err" object. Since an err has a "no
> error" state on it (the default constructor).

Done.

[cjhopman, 2014-10-16 18:26:05]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645253002/60001

[commit-bot: I haz the power, 2014-10-16 19:21:09]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2014-10-16 19:23:22]

Patchset 2 (id:??) landed as
https://crrev.com/86e95b3ce8e0e83f9d011e285b0a97313125cf1e
Cr-Commit-Position: refs/heads/master@{#299953}