content/browser/renderer_host/render_process_host_impl.cc - Issue 645233003: Revert of Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 645233003: Revert of Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index e44d46e796af43439074889dcc6d92847904883c..978916c009d46101ba764c358630c24d8b93f6eb 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -923,9 +923,6 @@

void RenderProcessHostImpl::AddRoute(

int32 routing_id,

IPC::Listener* listener) {

- // We already have DCHECK() in IDMap. This is for chasing

- // crbug.com/415059 and can be removed after fixing it.

- CHECK(!listeners_.Lookup(routing_id));

listeners_.AddWithID(listener, routing_id);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »