Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 645233003: Revert of Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() (Closed)

Created:
6 years, 2 months ago by kareng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() (patchset #1 id:1 of https://codereview.chromium.org/647623003/) Reason for revert: per bug https://code.google.com/p/chromium/issues/detail?id=422694 a bunch of crashes both in mac and windows today's canary. Original issue's description: > Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() > > This is an equivalent of DCHECK() in IDMap. > According to crbug.com/381990, this can occasionally crash. > I'd like to enable this to collect more data if it still crashes. > If you see this CHECK() being hit in the wild, > please revert this change and let me know. > > BUG=381990, 415059 > R=nasko@chromium.org, amineer@chromium.org > > Committed: https://crrev.com/9a8e3d71f73ace82874d53ba2e749b1173a98513 > Cr-Commit-Position: refs/heads/master@{#299146} TBR=amineer@chromium.org,nasko@chromium.org,karen@chromium.org,morrita@chromium.org NOTREECHECKS=true NOTRY=true BUG=381990, 415059 Committed: https://crrev.com/9a04b3c3f9c85da4510eba67095b61bec78d7b6b Cr-Commit-Position: refs/heads/master@{#299248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kareng
Created Revert of Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute()
6 years, 2 months ago (2014-10-11 19:30:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645233003/1
6 years, 2 months ago (2014-10-11 19:30:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-11 19:31:32 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 19:32:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a04b3c3f9c85da4510eba67095b61bec78d7b6b
Cr-Commit-Position: refs/heads/master@{#299248}

Powered by Google App Engine
This is Rietveld 408576698