[Telemetry] Restart browser in the case it hangs during unittests.

[Telemetry] Restart browser in the case it hangs during unittests.

This should unstick us if a unittest times out in a weird way.

BUG=418577
Committed: https://crrev.com/45097b2058e1a0d5049c9b7789a91aa9ea4f09ae
Cr-Commit-Position: refs/heads/master@{#299216}

[tonyg, 2014-10-10 22:39:27]

tonyg@chromium.org changed reviewers:
+ dtu@chromium.org

[dtu, 2014-10-10 22:51:33]

We didn't see any exceptions in this portion of the code.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

The exception is in PlayActionTest.setUp(), after it calls TabTestCase.setUp().

[tonyg, 2014-10-10 22:53:30]

On 2014/10/10 22:51:33, dtu wrote:
> We didn't see any exceptions in this portion of the code.
> 
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
> 
> The exception is in PlayActionTest.setUp(), after it calls
TabTestCase.setUp().

What about:

[ RUN      ] actions.play_unittest.PlayActionTest.testPlayWaitForPlayTimeout

Traceback (most recent call last):
  run at /usr/lib/python2.7/unittest/case.py:318
    self.setUp()
  setUp at tools/telemetry/telemetry/page/actions/play_unittest.py:18
    tab_test_case.TabTestCase.setUp(self)
  setUp at tools/telemetry/telemetry/unittest/tab_test_case.py:19
    self._browser.tabs[0].Close()
  Close at tools/telemetry/telemetry/core/tab.py:69
    self._backend_list.CloseTab(self._inspector_backend.debugger_url)
  CloseTab at
tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py:38
    util.WaitFor(lambda: tab_id not in self, timeout=5)
  WaitFor at tools/telemetry/telemetry/core/util.py:84
    (timeout, GetConditionString()))
TimeoutException: Timed out while waiting 5s for util.WaitFor(lambda: tab_id not
in self, timeout=5).


From
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

[dtu, 2014-10-10 22:59:01]

On 2014/10/10 22:53:30, tonyg wrote:
> On 2014/10/10 22:51:33, dtu wrote:
> > We didn't see any exceptions in this portion of the code.
> > 
> >
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
> > 
> > The exception is in PlayActionTest.setUp(), after it calls
> TabTestCase.setUp().
> 
> What about:
> 
> [ RUN      ] actions.play_unittest.PlayActionTest.testPlayWaitForPlayTimeout
> 
> Traceback (most recent call last):
>   run at /usr/lib/python2.7/unittest/case.py:318
>     self.setUp()
>   setUp at tools/telemetry/telemetry/page/actions/play_unittest.py:18
>     tab_test_case.TabTestCase.setUp(self)
>   setUp at tools/telemetry/telemetry/unittest/tab_test_case.py:19
>     self._browser.tabs[0].Close()
>   Close at tools/telemetry/telemetry/core/tab.py:69
>     self._backend_list.CloseTab(self._inspector_backend.debugger_url)
>   CloseTab at
> tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py:38
>     util.WaitFor(lambda: tab_id not in self, timeout=5)
>   WaitFor at tools/telemetry/telemetry/core/util.py:84
>     (timeout, GetConditionString()))
> TimeoutException: Timed out while waiting 5s for util.WaitFor(lambda: tab_id
not
> in self, timeout=5).
> 
> 
> From
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

Whoops, you're right. The third exception is in TabTestCase. lgtm % catch
TimeoutException, never catch Exception.

[tonyg, 2014-10-10 23:04:13]

> catch TimeoutException, never catch Exception.

Done

[tonyg, 2014-10-10 23:04:37]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-10-10 23:06:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645233002/150001

[commit-bot: I haz the power, 2014-10-11 00:10:03]

Committed patchset #2 (id:150001)

[commit-bot: I haz the power, 2014-10-11 00:10:49]

Patchset 2 (id:??) landed as
https://crrev.com/45097b2058e1a0d5049c9b7789a91aa9ea4f09ae
Cr-Commit-Position: refs/heads/master@{#299216}