Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 645223006: Use correct size for font style name search. (Closed)

Created:
6 years, 2 months ago by bungeman-skia
Modified:
6 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use correct size for font style name search. This fixes an out of bounds read introduced with a4c4a2d8cd65abb1e5ac20813831cdb9ace6c7ee "Replace SkTypeface::Style with SkFontStyle." BUG=chromium:425856 Committed: https://skia.googlesource.com/skia/+/d2ae72858eaa568e7f2511484f506140dc684a46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
6 years, 2 months ago (2014-10-22 15:13:35 UTC) #2
reed1
lgtm
6 years, 2 months ago (2014-10-22 15:15:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645223006/1
6 years, 2 months ago (2014-10-22 15:16:59 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 15:25:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as d2ae72858eaa568e7f2511484f506140dc684a46

Powered by Google App Engine
This is Rietveld 408576698