Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 645223003: Change overscroll functions to pass floats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // defined(OS_WIN) 10 #endif // defined(OS_WIN)
(...skipping 1179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 if (!handled) 1190 if (!handled)
1191 window()->HandleKeyboardEvent(event); 1191 window()->HandleKeyboardEvent(event);
1192 } 1192 }
1193 1193
1194 bool Browser::TabsNeedBeforeUnloadFired() { 1194 bool Browser::TabsNeedBeforeUnloadFired() {
1195 if (IsFastTabUnloadEnabled()) 1195 if (IsFastTabUnloadEnabled())
1196 return fast_unload_controller_->TabsNeedBeforeUnloadFired(); 1196 return fast_unload_controller_->TabsNeedBeforeUnloadFired();
1197 return unload_controller_->TabsNeedBeforeUnloadFired(); 1197 return unload_controller_->TabsNeedBeforeUnloadFired();
1198 } 1198 }
1199 1199
1200 void Browser::OverscrollUpdate(int delta_y) { 1200 void Browser::OverscrollUpdate(float delta_y) {
1201 window_->OverscrollUpdate(delta_y); 1201 window_->OverscrollUpdate(delta_y);
1202 } 1202 }
1203 1203
1204 void Browser::ShowValidationMessage(content::WebContents* web_contents, 1204 void Browser::ShowValidationMessage(content::WebContents* web_contents,
1205 const gfx::Rect& anchor_in_root_view, 1205 const gfx::Rect& anchor_in_root_view,
1206 const base::string16& main_text, 1206 const base::string16& main_text,
1207 const base::string16& sub_text) { 1207 const base::string16& sub_text) {
1208 RenderWidgetHostView* rwhv = web_contents->GetRenderWidgetHostView(); 1208 RenderWidgetHostView* rwhv = web_contents->GetRenderWidgetHostView();
1209 if (rwhv) { 1209 if (rwhv) {
1210 validation_message_bubble_ = 1210 validation_message_bubble_ =
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
2493 if (contents && !allow_js_access) { 2493 if (contents && !allow_js_access) {
2494 contents->web_contents()->GetController().LoadURL( 2494 contents->web_contents()->GetController().LoadURL(
2495 target_url, 2495 target_url,
2496 content::Referrer(), 2496 content::Referrer(),
2497 ui::PAGE_TRANSITION_LINK, 2497 ui::PAGE_TRANSITION_LINK,
2498 std::string()); // No extra headers. 2498 std::string()); // No extra headers.
2499 } 2499 }
2500 2500
2501 return contents != NULL; 2501 return contents != NULL;
2502 } 2502 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698