Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 645223003: Change overscroll functions to pass floats. (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change overscroll functions to pass floats. The source values for these are floats, and the lone nontrivial consumer (athena) wants floats. So avoid truncating to int in the meantime. BUG=81439 TEST=none Committed: https://crrev.com/58e3dc6d40ebe536636c5e187a79babe3d04bd87 Cr-Commit-Position: refs/heads/master@{#299347}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M athena/content/web_activity.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/scroll_end_effect_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/scroll_end_effect_controller_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/scroll_end_effect_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 4 chunks +12 lines, -9 lines 1 comment Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Kasting
sky: athena/, chrome/ OWNERS avi: content/ OWNERS (will TBR if necessary, change is trivial) https://codereview.chromium.org/645223003/diff/1/content/browser/web_contents/web_contents_view_aura.cc ...
6 years, 2 months ago (2014-10-11 00:11:06 UTC) #2
Avi (use Gerrit)
lgtm boring
6 years, 2 months ago (2014-10-11 03:07:54 UTC) #3
sky
LGTM
6 years, 2 months ago (2014-10-13 17:17:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645223003/1
6 years, 2 months ago (2014-10-13 18:01:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 19:49:05 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:49:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58e3dc6d40ebe536636c5e187a79babe3d04bd87
Cr-Commit-Position: refs/heads/master@{#299347}

Powered by Google App Engine
This is Rietveld 408576698