Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 645223002: Add back support for /Gv now that gyp-win64 has VS2013 (Closed)

Created:
6 years, 2 months ago by Shezan Baig (Bloomberg)
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add back support for /Gv now that gyp-win64 has VS2013 This was removed in the last minute in r1984 because of failures in the gyp-win64 bot. BUG= R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=2007

Patch Set 1 #

Patch Set 2 : Enable vectorcall test only if we have at least 2013 #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M pylib/gyp/MSVSSettings.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pylib/gyp/MSVSSettings_test.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/win/compiler-flags/calling-convention.gyp View 1 1 chunk +20 lines, -1 line 0 comments Download
A + test/win/compiler-flags/calling-convention-vectorcall.def View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Shezan Baig (Bloomberg)
6 years, 2 months ago (2014-10-10 22:24:53 UTC) #2
scottmg
It's still running on 2012, I'll send you a CL to switch it.
6 years, 2 months ago (2014-10-10 22:29:37 UTC) #3
Shezan Baig (Bloomberg)
On 2014/10/10 22:29:37, scottmg wrote: > It's still running on 2012, I'll send you a ...
6 years, 2 months ago (2014-10-12 12:04:32 UTC) #4
scottmg
Sorry, forgot about this, should be landable now. lgtm.
6 years, 1 month ago (2014-11-19 20:13:30 UTC) #5
Shezan Baig (Bloomberg)
On 2014/11/19 20:13:30, scottmg wrote: > Sorry, forgot about this, should be landable now. lgtm. ...
6 years, 1 month ago (2014-11-19 20:21:54 UTC) #6
scottmg
On 2014/11/19 20:21:54, Shezan Baig (Bloomberg) wrote: > On 2014/11/19 20:13:30, scottmg wrote: > > ...
6 years, 1 month ago (2014-11-19 20:24:26 UTC) #7
Shezan Baig (Bloomberg)
On 2014/11/19 20:24:26, scottmg wrote: > On 2014/11/19 20:21:54, Shezan Baig (Bloomberg) wrote: > > ...
6 years, 1 month ago (2014-11-19 20:27:42 UTC) #8
Shezan Baig (Bloomberg)
6 years, 1 month ago (2014-11-21 14:30:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:220001) manually as 2007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698