Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: content/browser/plugin_service_impl.cc

Issue 645203002: Block NPAPI plugins by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missing test file Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/plugin_service_impl.cc
diff --git a/content/browser/plugin_service_impl.cc b/content/browser/plugin_service_impl.cc
index 1b7ad7641c43cbb8d517b76869f17def73732935..3b8c2197ed91deac303d0658a7097b9f25fc802d 100644
--- a/content/browser/plugin_service_impl.cc
+++ b/content/browser/plugin_service_impl.cc
@@ -190,6 +190,9 @@ void PluginServiceImpl::Init() {
if (command_line->HasSwitch(switches::kDisablePluginsDiscovery))
PluginList::Singleton()->DisablePluginsDiscovery();
+#if defined(OS_WIN) || defined(OS_MACOSX)
+ npapi_plugins_enabled_ = command_line->HasSwitch(switches::kEnableNpapi);
+#endif
}
void PluginServiceImpl::StartWatchingPlugins() {
@@ -801,7 +804,7 @@ void PluginServiceImpl::GetInternalPlugins(
bool PluginServiceImpl::NPAPIPluginsSupported() {
#if defined(OS_WIN) || defined(OS_MACOSX)
- return true;
+ return npapi_plugins_enabled_;
#else
return false;
#endif
@@ -811,6 +814,12 @@ void PluginServiceImpl::DisablePluginsDiscoveryForTesting() {
PluginList::Singleton()->DisablePluginsDiscovery();
}
+#if defined(OS_WIN) || defined(OS_MACOSX)
+void PluginServiceImpl::EnableNpapiPluginsForTesting() {
+ npapi_plugins_enabled_ = true;
+}
+#endif
+
#if defined(OS_MACOSX)
void PluginServiceImpl::AppActivated() {
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698