Block NPAPI plugins by default

chrome/browser/content_settings/content_settings_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
@@ skipping 276 matching lines @@
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   EXPECT_TRUE(TabSpecificContentSettings::FromWebContents(web_contents)->
       IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));
 }
 
 // On Aura NPAPI only works on Windows.
 #if !defined(USE_AURA) || defined(OS_WIN)
 
-class ClickToPlayPluginTest : public ContentSettingsTest {
- public:
-  ClickToPlayPluginTest() {}
+class LoadPluginTest : public ContentSettingsTest {
+ protected:
+  void PerformTest(bool expect_loaded) {
+    GURL url = ui_test_utils::GetTestUrl(
+        base::FilePath(),
+        base::FilePath().AppendASCII("load_npapi_plugin.html"));
+    ui_test_utils::NavigateToURL(browser(), url);
 
+    const char* expected_result = expect_loaded ? "Loaded" : "Not Loaded";
+    const char* unexpected_result = expect_loaded ? "Not Loaded" : "Loaded";
+
+    base::string16 expected_title(base::ASCIIToUTF16(expected_result));
+    base::string16 unexpected_title(base::ASCIIToUTF16(unexpected_result));
+
+    content::TitleWatcher title_watcher(
+        browser()->tab_strip_model()->GetActiveWebContents(), expected_title);
+    title_watcher.AlsoWaitForTitle(unexpected_title);
+
+    EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle());
+  }
+
+  void SetUpCommandLineInternal(CommandLine* command_line, bool expect_loaded) {
 #if defined(OS_MACOSX)
-  virtual void SetUpCommandLine(CommandLine* command_line) override {
     base::FilePath plugin_dir;
     PathService::Get(base::DIR_MODULE, &plugin_dir);
     plugin_dir = plugin_dir.AppendASCII("plugins");
     // The plugins directory isn't read by default on the Mac, so it needs to be
     // explicitly registered.
     command_line->AppendSwitchPath(switches::kExtraPluginDir, plugin_dir);
+#endif
+    command_line->AppendSwitch(switches::kAlwaysAuthorizePlugins);
+#if defined(OS_MACOSX) || defined(OS_WIN)

[jam, 2014/10/20 15:50:32]

ditto

[Will Harris, 2014/10/20 17:59:56]

Done.

+    if (expect_loaded)
+      command_line->AppendSwitch(switches::kEnableNpapi);
+#endif
+  }
+};
+
+class DisabledPluginTest : public LoadPluginTest {
+ public:
+  DisabledPluginTest() {}
+
+  virtual void SetUpCommandLine(CommandLine* command_line) override {
+    SetUpCommandLineInternal(command_line, false);
+  }
+};
+
+IN_PROC_BROWSER_TEST_F(DisabledPluginTest, Load) {
+  PerformTest(false);
+}
+
+class EnabledPluginTest : public LoadPluginTest {
+ public:
+  EnabledPluginTest() {}
+
+  virtual void SetUpCommandLine(CommandLine* command_line) override {
+    SetUpCommandLineInternal(command_line, true);
+  }
+};
+
+IN_PROC_BROWSER_TEST_F(EnabledPluginTest, Load) {
+  PerformTest(true);
+}
+
+class ClickToPlayPluginTest : public ContentSettingsTest {
+ public:
+  ClickToPlayPluginTest() {}
+#if defined(OS_WIN) || defined(OS_MACOSX)
+  virtual void SetUpCommandLine(CommandLine* command_line) override {
+#if defined(OS_MACOSX)
+    base::FilePath plugin_dir;
+    PathService::Get(base::DIR_MODULE, &plugin_dir);
+    plugin_dir = plugin_dir.AppendASCII("plugins");
+    // The plugins directory isn't read by default on the Mac, so it needs to be
+    // explicitly registered.
+    command_line->AppendSwitchPath(switches::kExtraPluginDir, plugin_dir);
+#endif
+    command_line->AppendSwitch(switches::kEnableNpapi);
   }
 #endif
 };
 
 IN_PROC_BROWSER_TEST_F(ClickToPlayPluginTest, Basic) {
   browser()->profile()->GetHostContentSettingsMap()->SetDefaultContentSetting(
       CONTENT_SETTINGS_TYPE_PLUGINS, CONTENT_SETTING_BLOCK);
 
   GURL url = ui_test_utils::GetTestUrl(
       base::FilePath(), base::FilePath().AppendASCII("clicktoplay.html"));
@@ skipping 408 matching lines @@
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
   RunJavaScriptBlockedTest("load_nacl_no_js.html", true);
 }
 #endif  // !defined(DISABLE_NACL)
 
 #endif  // defined(ENABLE_PLUGINS)