Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6452010: Remove the x-ppapi-nacl-srpc and x-nacl-srpc mime types in favor of the singl... (Closed)

Created:
9 years, 10 months ago by sehr (please use chromium)
Modified:
9 years, 7 months ago
Reviewers:
polina, der Springer
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the x-ppapi-nacl-srpc and x-nacl-srpc mime types in favor of the single mime type application/x-nacl. BUG=none TEST=every browser test (Chrome and not) Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4286

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -2699 lines) Patch
M src/trusted/plugin/build.scons View 1 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/plugin/nacl_entry_points.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/plugin/npapi/npp_launcher.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/trusted/plugin/osx/Info.plist View 1 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/plugin/osx/npGoogleNaClPlugin.r View 1 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/plugin/osx_ppapi/Info.plist View 1 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/plugin/osx_ppapi/ppNaClPlugin.r View 1 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/plugin/win/nacl_plugin.rc View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/autoloader/autoloader_default.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/cdom_perf/cdom_perf.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/client_translator/translator.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/contest_issues/issue42.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/contest_issues/issue44.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/contest_issues/issue45.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/contest_issues/issue49.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/contest_issues/issue52.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/contest_issues/issue53.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/contest_issues/issue54.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/contest_issues/issue55.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/contest_issues/issue57.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/contest_issues/issue58.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/contest_issues/issue62.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/contest_issues/issue63.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/drawing/drawing.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/earth/earth.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/fake_browser/fake_browser_test.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M tests/inbrowser_test_runner/test_runner.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/life/life.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lua/lua.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/mandel/mandel_tiled.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/mandel_nav/mandel_nav.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/many/many18.html View 1 1 chunk +18 lines, -18 lines 0 comments Download
M tests/many/many3.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/many/many36.html View 1 1 chunk +36 lines, -36 lines 0 comments Download
M tests/many/many9.html View 1 1 chunk +9 lines, -9 lines 0 comments Download
M tests/many/mix.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/multiarch/multiarch.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/photo/photo.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_bad/ppapi_bad.html View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tests/ppapi_core/ppapi_core.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_example_2d/ppapi_example_2d.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_example_2d/ppapi_example_2d.stdin View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_example_audio/ppapi_example_audio.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_geturl/build.scons View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_geturl/ppapi_geturl.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_proxy/basic_object.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_proxy/event_example.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ppapi_proxy/event_example.stdin View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/srpc_hw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/npapi_hw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/pepper_plugin.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/prebuilt/x64/srpc_basic.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/srpc_hw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/srpc_hw_ppapi.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/srpc_nrd_xfer.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/prebuilt/x64/srpc_plugin.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/srpc_shm.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x64/srpc_sockaddr.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/OldAbiVersion/srpc_hw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/npapi_hw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/pepper_plugin.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/prebuilt/x86/srpc_basic.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/srpc_hw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/srpc_hw_ppapi.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/srpc_nrd_xfer.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/prebuilt/x86/srpc_plugin.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/srpc_shm.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/prebuilt/x86/srpc_sockaddr.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/quake/quake.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/quake/quake3.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/quake/quake9.html View 1 1 chunk +9 lines, -9 lines 0 comments Download
M tests/ruby/ruby.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/examples_ppapi.html View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
M tests/srpc/nacl.scons View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tests/srpc/srpc_basic.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_basic_ppapi.html View 1 1 chunk +0 lines, -697 lines 0 comments Download
M tests/srpc/srpc_display_shm.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_nrd_xfer.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/srpc/srpc_nrd_xfer_ppapi.html View 1 1 chunk +0 lines, -302 lines 0 comments Download
M tests/srpc/srpc_perf.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_perf_ppapi.html View 1 1 chunk +0 lines, -145 lines 0 comments Download
M tests/srpc/srpc_plugin.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_plugin_ppapi.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_shm.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_shm_ppapi.html View 1 1 chunk +0 lines, -761 lines 0 comments Download
M tests/srpc/srpc_sockaddr.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_sockaddr_ppapi.html View 1 1 chunk +0 lines, -252 lines 0 comments Download
M tests/srpc/srpc_url_as_nacl_desc.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc/srpc_url_as_nacl_desc_ppapi.html View 1 1 chunk +0 lines, -250 lines 0 comments Download
M tests/srpc_hw/srpc_hw.html View 1 2 3 4 5 2 chunks +13 lines, -8 lines 0 comments Download
M tests/srpc_hw/srpc_hw_fd.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/srpc_hw/srpc_hw_ppapi.html View 1 2 3 4 1 chunk +0 lines, -85 lines 0 comments Download
M tests/vim/vim.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/voronoi/voronoi.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/xaos/xaos.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/google-chrome-wrapper.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sehr (please use chromium)
This is the follow-up to the __urlAsNaClDesc change. Consolidate the mime type names.
9 years, 10 months ago (2011-02-08 18:17:50 UTC) #1
polina
http://codereview.chromium.org/6452010/diff/1/tests/srpc/nacl.scons File tests/srpc/nacl.scons (left): http://codereview.chromium.org/6452010/diff/1/tests/srpc/nacl.scons#oldcode16 tests/srpc/nacl.scons:16: # TODO(polina): at some point there should only be ...
9 years, 10 months ago (2011-02-09 00:25:20 UTC) #2
sehr (please use chromium)
Thanks for that suggestion. PTAL. http://codereview.chromium.org/6452010/diff/1/tests/srpc/nacl.scons File tests/srpc/nacl.scons (left): http://codereview.chromium.org/6452010/diff/1/tests/srpc/nacl.scons#oldcode16 tests/srpc/nacl.scons:16: # TODO(polina): at some ...
9 years, 10 months ago (2011-02-09 17:18:03 UTC) #3
polina
http://codereview.chromium.org/6452010/diff/7001/tests/srpc/examples_ppapi.html File tests/srpc/examples_ppapi.html (left): http://codereview.chromium.org/6452010/diff/7001/tests/srpc/examples_ppapi.html#oldcode21 tests/srpc/examples_ppapi.html:21: [ 'plugin properties', 'srpc_plugin_ppapi.html' ], this should stay as ...
9 years, 10 months ago (2011-02-09 19:39:00 UTC) #4
sehr (please use chromium)
Thanks for the review. One change made, one not. http://codereview.chromium.org/6452010/diff/7001/tests/srpc/examples_ppapi.html File tests/srpc/examples_ppapi.html (left): http://codereview.chromium.org/6452010/diff/7001/tests/srpc/examples_ppapi.html#oldcode21 tests/srpc/examples_ppapi.html:21: ...
9 years, 10 months ago (2011-02-09 19:58:01 UTC) #5
sehr (please use chromium)
Ok, I confirmed that we're not running selenium tests expecting popups rather than element updates, ...
9 years, 10 months ago (2011-02-09 20:54:34 UTC) #6
polina
LGTM http://codereview.chromium.org/6452010/diff/27001/tests/srpc_hw/srpc_hw.html File tests/srpc_hw/srpc_hw.html (right): http://codereview.chromium.org/6452010/diff/27001/tests/srpc_hw/srpc_hw.html#newcode12 tests/srpc_hw/srpc_hw.html:12: function $(id) { This helper is used only ...
9 years, 10 months ago (2011-02-09 21:54:41 UTC) #7
polina
LGTM
9 years, 10 months ago (2011-02-09 21:56:53 UTC) #8
sehr (please use chromium)
9 years, 10 months ago (2011-02-09 21:58:12 UTC) #9 
On 2011/02/09 21:56:53, polina wrote:
> LGTM

committed as r4286.

Powered by Google App Engine
This is Rietveld 408576698