Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 645143003: tools/valgrind: Add function for ui_base_unittests target variant. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, Derek Bruening, cmp, iannucci, M-A Ruel, ghost stip (do not use), Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

tools/valgrind: Add function for ui_base_unittests target variant. This will replace 'ui_unittests' soon. BUG=331829, 373148, 299841, 103304 TEST=None R=glider@chromium.org,timurrrr@chromium.org Committed: https://crrev.com/ced73ad0c3673f0a23a6b39885fd7278bacb3cce Cr-Commit-Position: refs/heads/master@{#300624}

Patch Set 1 #

Total comments: 1

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/chrome_tests.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tfarina
Is this correct? I think I need this to update the references in masters/master.chromium.memory.fyi. If ...
6 years, 2 months ago (2014-10-21 02:43:56 UTC) #1
ghost stip (do not use)
this one I'm far less knowledgeable about. you should get phajdan.jr to look over it
6 years, 2 months ago (2014-10-21 02:45:43 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/645143003/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/645143003/diff/1/tools/valgrind/chrome_tests.py#newcode481 tools/valgrind/chrome_tests.py:481: def TestUIBaseUnit(self): Ideally in alphabetical order above ui_unittests. ...
6 years, 2 months ago (2014-10-21 10:43:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645143003/20001
6 years, 2 months ago (2014-10-22 01:47:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 02:36:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ced73ad0c3673f0a23a6b39885fd7278bacb3cce
Cr-Commit-Position: refs/heads/master@{#300624}

Powered by Google App Engine
This is Rietveld 408576698