Prefix CommandLine usege with base namespace (Part 1: base/)

Prefix CommandLine usege with base namespace (Part 1: base/)

Prefix all CommandLine usage in the base/ directory with the
base:: namespace.

BUG=422426
Committed: https://crrev.com/421dddbfb62bc44bcab42c454ed913b337f849b9
Cr-Commit-Position: refs/heads/master@{#305626}

[elecro, 2014-10-10 18:50:08]

pgal.u-szeged@partner.samsung.com changed reviewers:
+ brettw@chromium.org, jshin@chromium.org, nduca@chromium.org,
nyquist@chromium.org, phajdan@google.com, rvargas@chromium.org

[elecro, 2014-10-10 18:50:08]

PTAL

[rvargas (doing something else), 2014-10-11 01:06:13]

Code from base should generally live within the base namespace so it doesn't
need a base:: prefix

[brettw, 2014-10-11 03:34:23]

Yeah, the base:: thing is really for stuff outside of base.

[elecro, 2014-10-14 12:37:44]

On 2014/10/11 01:06:13, rvargas wrote:
> Code from base should generally live within the base namespace so it doesn't
> need a base:: prefix

Well, there are a few files which are not in the base namespace, like the
logging.cc. It uses the logging namespace, so if I don't specify the base::
there and remove the "using base::CommandLine" from the command_line.h, then it
won't compile at all. 

But you are right I've even added the base:: prefix in some files even they are
in that namespace.

[elecro, 2014-10-14 16:18:29]

I've updated the CL, and now only the files which are not inside the base
namespace are modified.

[brettw, 2014-10-14 17:46:57]

https://codereview.chromium.org/645133002/diff/280001/base/command_line_unitt...
File base/command_line_unittest.cc (right):

https://codereview.chromium.org/645133002/diff/280001/base/command_line_unitt...
base/command_line_unittest.cc:14: using base::FilePath;
Instead of making the base:: additionss in this file, can you wrap the whole
thing in the base namespace, and also remove this using statement?

https://codereview.chromium.org/645133002/diff/280001/base/test/launcher/test...
File base/test/launcher/test_results_tracker.h (right):

https://codereview.chromium.org/645133002/diff/280001/base/test/launcher/test...
base/test/launcher/test_results_tracker.h:38: bool Init(const base::CommandLine&
command_line) WARN_UNUSED_RESULT;
This file is already in base.

[elecro, 2014-10-15 08:44:40]

On 2014/10/14 17:46:57, brettw wrote:
>
https://codereview.chromium.org/645133002/diff/280001/base/command_line_unitt...
> File base/command_line_unittest.cc (right):
> 
>
https://codereview.chromium.org/645133002/diff/280001/base/command_line_unitt...
> base/command_line_unittest.cc:14: using base::FilePath;
> Instead of making the base:: additionss in this file, can you wrap the whole
> thing in the base namespace, and also remove this using statement?
> 

Done, also removed some additional base:: usages one of the methods.

>
https://codereview.chromium.org/645133002/diff/280001/base/test/launcher/test...
> File base/test/launcher/test_results_tracker.h (right):
> 
>
https://codereview.chromium.org/645133002/diff/280001/base/test/launcher/test...
> base/test/launcher/test_results_tracker.h:38: bool Init(const
base::CommandLine&
> command_line) WARN_UNUSED_RESULT;
> This file is already in base.

Ooops... missed that. Now fixed.

[elecro, 2014-10-20 16:23:00]

ping?

[rvargas (doing something else), 2014-10-22 01:43:38]

https://codereview.chromium.org/645133002/diff/300001/base/test/test_timeouts.cc
File base/test/test_timeouts.cc (right):

https://codereview.chromium.org/645133002/diff/300001/base/test/test_timeouts...
base/test/test_timeouts.cc:46: GetSwitchValueASCII(switch_name));
nit: indentation is off

[elecro, 2014-10-22 12:12:19]

On 2014/10/22 01:43:38, rvargas wrote:
>
https://codereview.chromium.org/645133002/diff/300001/base/test/test_timeouts.cc
> File base/test/test_timeouts.cc (right):
> 
>
https://codereview.chromium.org/645133002/diff/300001/base/test/test_timeouts...
> base/test/test_timeouts.cc:46: GetSwitchValueASCII(switch_name));
> nit: indentation is off

Thanks. I've rebased the cl and fixed the indentation.

[rvargas (doing something else), 2014-10-23 00:15:37]

lgtm

[elecro, 2014-10-28 16:39:09]

pgal.u-szeged@partner.samsung.com changed reviewers:
+ phajdan.jr@chromium.org
- nduca@chromium.org, nyquist@chromium.org, phajdan@google.com

[elecro, 2014-10-28 16:39:09]

ping:
jshin@ for i18n/
phajdan.jr@ for test/

[Paweł Hajdan Jr., 2014-10-29 10:18:25]

base/test LGTM

[jungshik at Google, 2014-11-13 23:31:14]

base/i18n LGTM

[elecro, 2014-11-25 11:49:18]

The CQ bit was checked by pgal.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-11-25 11:50:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645133002/340001

[commit-bot: I haz the power, 2014-11-25 12:55:10]

Committed patchset #5 (id:340001)

[commit-bot: I haz the power, 2014-11-25 12:55:48]

Patchset 5 (id:??) landed as
https://crrev.com/421dddbfb62bc44bcab42c454ed913b337f849b9
Cr-Commit-Position: refs/heads/master@{#305626}

[brettw, 2014-11-25 18:29:49]

Please stop adding me to these reviews unless you actually need me to review
something (and then make it clear what exactly you need). Thanks!