Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 645073002: Remove unused variables in the relocation packer. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused variables in the relocation packer. Fixes, in clang/gn builds, four occurrences of: ../../tools/relocation_packer/src/elf_file.cc: error: unused variable... BUG=385553 Committed: https://crrev.com/ec6aa278c5e9361feb340753d5174dec21556e15 Cr-Commit-Position: refs/heads/master@{#299279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/relocation_packer/src/elf_file.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-10 16:16:12 UTC) #2
rmcilroy
On 2014/10/10 16:16:12, simonb wrote: lgtm, thanks.
6 years, 2 months ago (2014-10-11 11:58:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645073002/1
6 years, 2 months ago (2014-10-13 10:21:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 10:37:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 10:38:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec6aa278c5e9361feb340753d5174dec21556e15
Cr-Commit-Position: refs/heads/master@{#299279}

Powered by Google App Engine
This is Rietveld 408576698